Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM builds are useful for those wanting to generate keys on an offline ARM machine, most accessible of which is a raspberry pi. Currently, to use eth2.0-deposit-cli on an ARM machine, the user must connect to the internet to install dependencies. This defeats the purpose of an offline machine. This PR would close #82 .
The first commit creates
build-linux-arm
, a copy ofbuild-linux
which uses an ARM CI environment, freely supported by Circle CI. However, the current specified version of PyInstaller (3.6) required for building the binary fails to compile due to warnings and-Werror
: Circle CI link for the first commit.The second commit updates PyInstaller to the latest version (4.7). Just doing this also fails, as transitive dependencies of PyInstaller are not pinned to a specific version, which is required by the hashes. Just as in the project's root
requirements.txt
, the specific versions of transitive dependencies are specified at the bottom ofbuild_configs/linux/requirements.txt
. Since these dependencies were only specified with>=
, I opted to use the latest versions of the underspecified packages (links provided for convenient checking of the hashes):The
build-linux
CI job continues to pass with the updated dependencies: Circle CI link forbuild-linux
andbuild-linux-arm
. I tested the ARM artifacts produced on an emulated qemu ARM vm and it seems to work fine. I will test on a raspberry pi later today