Make --execution_address and --eth1_withdrawal_address compatible alias
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
force-pushed
the
execution-address-alias
branch
from
229eb07 to
4064f12
Compare
CarlBeek
approved these changes
Mar 14, 2023
everhusk
pushed a commit
to earthbitcoin/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Make `--execution_address` and `--eth1_withdrawal_address` compatible alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In deposit commands, the option is called
--eth1_withdrawal_address. But in BTEC, we use--execution_addressbecause (1) it's the parameter of the spec and (2) generally removes "eth1" terminology.How did I fix it
JITOption.param_declsaccept a list of parameter declarations likeclick.Option.--execution_addressand--eth1_withdrawal_addresscompatible aliasWarning
In the case that user somehow types in BOTH
--eth1_withdrawal_addressand--execution_address,clickby default will override the previous with the latter. I tried to raise exception by implementingclick.Option.type_cast_valueAPI, but my changes were not compatible with our other parameters. It should be fix, but I think this PR is ready to be included in the release now.