Add a test that fails before PR 4482 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a test on ecpairing where g1 is invalid while g2 is zero. cpp-ethereum before PR 4482 accidentially returned some answer in this case. It should throw.
pirapira
changed the title
winsvega
reviewed
Sep 18, 2017
| } | ||
| } | ||
| ], | ||
| "explanation": "Puts the given data into the ECPAIRING precompile" |
There was a problem hiding this comment.
we agreed to use //for comments in the fillers
and if you want the comment to end up in generated test fill the description into
"_info" : {
"comment" : ""
}
_info.comment should be copied to the final test when filling
|
@winsvega I added a comment in |
winsvega
reviewed
Sep 19, 2017
| { | ||
| "ecpairing_one_point_with_g2_zero_and_g1_invalid" : { | ||
| "_info" : { | ||
| "comment" : "", |
There was a problem hiding this comment.
this field should be filled by testeth if there is one in a filler file
There was a problem hiding this comment.
testeth does not do that. So testeth has a bug.
winsvega
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test on ecpairing where g1 is invalid while g2 is zero.
cpp-ethereum before PR 4482 accidentially returned some answer in this case. It should throw.