Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain test format doc updates on seal engine type #533

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

holgerd77
Copy link
Contributor

Solves issues raised on #530.

@holgerd77 holgerd77 requested review from winsvega and holiman October 22, 2018 12:19
@winsvega
Copy link
Collaborator

could you also note that this field is optional and there are still tests without "sealEngine" filed.
such tests are equvalent to "sealEngine" : "NoProof"

@holgerd77
Copy link
Contributor Author

Ok, will do.

@holgerd77 holgerd77 force-pushed the blockchain-test-format-doc-updates branch from f2b5802 to 2daa4ab Compare October 23, 2018 11:15
@holgerd77
Copy link
Contributor Author

Ok, just updated and added an additional note on this.

@holgerd77
Copy link
Contributor Author

Can this be merged now?

@winsvega winsvega merged commit 2cd62ae into develop Oct 24, 2018
@axic axic deleted the blockchain-test-format-doc-updates branch October 25, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants