Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate all test files with fields sorted #931

Merged
merged 1 commit into from
Sep 11, 2021
Merged

regenerate all test files with fields sorted #931

merged 1 commit into from
Sep 11, 2021

Conversation

winsvega
Copy link
Collaborator

No description provided.

@winsvega winsvega changed the title regenerate all tests with sorting regenerate all test files with fields sorted Aug 29, 2021
@holiman
Copy link
Contributor

holiman commented Sep 2, 2021

I'm running the tests now. I think you should modify how these files are handled. Whenever a test is regenerated, you should have a step where you compare the existing file (if present) with the new file. The comparison should be json-based, and

  • Should ignore (recursively) certain fields, e.g. dates, generated-by-comments.
  • Should ignore ordering in maps

Ideally, it would be in the filler-to-test pipeline, and it would simply skip overwriting the file in the first place.

@holiman
Copy link
Contributor

holiman commented Sep 2, 2021

Test passed btw, lgtm!

@winsvega
Copy link
Collaborator Author

winsvega commented Sep 4, 2021

ordering in maps is ignorred, thats just for prettiness.

I was thinking about this, however I have some logical problem if test is regenerated then dates and versions should be updated. it would be strange to regenerate the test and make no changes.

however because of the github when there are really no changes made to the tests, then it actually makes sense.
this might require one more field in the info section - hash sum of the rest of the test. so if no changes then hash is the same I can quicly compare.

@winsvega winsvega merged commit e102032 into develop Sep 11, 2021
@winsvega winsvega deleted the updateall branch September 11, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants