This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Test package ci #106
Merged
Test package ci #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
force-pushed
the
test-package-ci
branch
from
104c79c to
a7accd5
Compare
pipermerriam
approved these changes
Jan 7, 2019
xdist was not using the locally packaged trinity for tests, so we had to disable it to correctly test packages. But when xdist is removed, the -n parameter that's in the environment causes pytest to fail. Having a different environment on circle than local tests is likely to cause future problems of a similar variety anyway, so let's just remove the variable. This requires manually setting '-n 4' on the tests that make sense with it, but making that value explicit seems like an improvement.
carver
force-pushed
the
test-package-ci
branch
from
a7accd5 to
b0ba2f9
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Migrated from ethereum/py-evm#1643
#97 - no CI test of the packaged release
How was it fixed?
Add a new tox and circle run against the packaged release.
Cute Animal Picture