Mark Geth's replaceTransaction_already_mined test as flaky

ethereum · Jan 14, 2021 · 954efed · 954efed
1 parent c934ca4
commit 954efed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/newsfragments/1834.misc.rst b/newsfragments/1834.misc.rst
@@ -0,0 +1 @@
+Mark Geth's replaceTransaction_already_mined test as flaky
diff --git a/tests/integration/go_ethereum/common.py b/tests/integration/go_ethereum/common.py
@@ -1,3 +1,6 @@
+from concurrent.futures._base import (
+    TimeoutError as FuturesTimeoutError,
+)
 import pytest
 
 from web3._utils.module_testing import (  # noqa: F401
@@ -21,6 +24,11 @@ def test_eth_submitHashrate(self, web3):
         # https://github.com/ethereum/go-ethereum/commit/51db5975cc5fb88db6a0dba1826b534fd4df29d7
         super().test_eth_submitHashrate(web3)
 
+    @pytest.mark.xfail(
+        strict=False,
+        raises=FuturesTimeoutError,
+        reason='Sometimes a TimeoutError is hit when waiting for the txn to be mined',
+    )
     def test_eth_replaceTransaction_already_mined(self, web3, unlocked_account_dual_type):
         web3.geth.miner.start()
         super().test_eth_replaceTransaction_already_mined(web3, unlocked_account_dual_type)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Mark Geth's replaceTransaction_already_mined test as flaky