Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against parity v2 #1063

Closed
wants to merge 2 commits into from
Closed

Conversation

dylanjw
Copy link
Contributor

@dylanjw dylanjw commented Sep 18, 2018

What was wrong?

Parity 2.0.5 stable has been released.

How was it fixed?

Cute Animal Picture

image

@dylanjw dylanjw force-pushed the bump_parity_version branch from ea631dc to d1ac5bf Compare September 18, 2018 23:33
@dylanjw
Copy link
Contributor Author

dylanjw commented Sep 19, 2018

Appears that the parity test fixtures need to be updated for v2. The past strategy of setting up the fixtures with go-ethereum and exporting, then importing the chain data into parity is hitting an error:

2018-09-18 17:40:30  Stage 5 block verification failed for #1 (0xf1b0…1efb)
Error: Error(Block(InvalidStateRoot(Mismatch { expected: 0x9993ce1966f02d1401e5472a3814a11fe55d53712550ca6c947819c3759b3c33, found: 0xbae0c4f770633c7657d6c1dc387482007619d62fd6751f0a6cc0afa858ee6301 })), State { next_error: None, backtrace: InternalBacktrace { backtrace: None } })

Next task is changing the parity fixture generation script to set up the chain state in parity directly with a miner.

@dylanjw dylanjw changed the title Test against latest stable parity Test against parity v2 Sep 19, 2018
@carver
Copy link
Collaborator

carver commented Sep 19, 2018

The past strategy of setting up the fixtures with go-ethereum and exporting, then importing the chain data into parity is hitting an error

Hm, that's unexpected. The blocks should all be valid.

@dylanjw
Copy link
Contributor Author

dylanjw commented Sep 24, 2018

Hm, that's unexpected. The blocks should all be valid.

Figuring out a private chain config that is cross compatible with newer versions of go-ethereum and parity v2 has been challenging. For previous versions of parity I used a modified version of this chain spec: https://github.com/5chdn/crossclient-chainspec. This is no longer working, and reading through parity and go-ethereum to figure out the differences in default EIP transitions has been tedious and unfruitful. The next thing I will try is setting up a private chain in parity along with ethminer.

@carver
Copy link
Collaborator

carver commented Sep 24, 2018

Ah, I forgot the process. I thought we were syncing parity one from geth, which I would expect to work.

@kclowes
Copy link
Collaborator

kclowes commented Aug 7, 2019

Closing since this has been taken care of in #1292!

@kclowes kclowes closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants