Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a yaml file for Read the Docs #1162

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Dec 13, 2018

What was wrong?

Read the Docs build is failing because it's running Python 3.5.2 and we specify that we need Python 3.5.3 or higher.

How was it fixed?

Added a .readthedocs.yml file

Cute Animal Picture

image7

@carver
Copy link
Collaborator

carver commented Dec 13, 2018

Ooh right, I forgot about that yaml. I think there's some way to trigger a build on the branch (esp if the branch gets pushed upstream) to test it out.

For whatever reason, we used a slightly different yaml in v4:

build:
image: latest

I don't remember why we used that approach. You might try to blame it and see if there's any more information in the old PR about what was tried.

@kclowes
Copy link
Collaborator Author

kclowes commented Dec 13, 2018

I think there's some way to trigger a build on the branch (esp if the branch gets pushed upstream) to test it out.

ooo, sweet! I'll check it out

For whatever reason, we used a slightly different yaml in v4:

Neat! I didn't even see that one. It looks like build.latest should work. Do you have a preference between cherry picking that commit or updating the file here?

@carver
Copy link
Collaborator

carver commented Dec 13, 2018

Do you have a preference between cherry picking that commit or updating the file here?

No need to cherry-pick it, update in place is fine. 👍

@kclowes kclowes merged commit 911e2a4 into ethereum:master Dec 13, 2018
@kclowes kclowes deleted the add-rtd-yml branch December 13, 2018 23:51
@pipermerriam
Copy link
Member

This might belong in https://github.com/ethereum/ethereum-python-project-template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants