Change manager.providers from list to single manager.provider (V5 beta) #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
update-manager-providers-to-single-provider
branch
10 times, most recently
from
d95861b to
b880aa7
Compare
kclowes
reviewed
Jan 11, 2019
web3/main.py
Outdated
| for provider in self.providers: | ||
| if provider.isConnected(): | ||
| return True | ||
| if self.provider.isConnected(): |
There was a problem hiding this comment.
This is a nitpick, but can we just say return self.provider.isConnected()? Or is it a pythonic thing to have the explicit return True?
There was a problem hiding this comment.
Not sure if it's more or less "pythonic", but I do like your suggestion better, will update!
njgheorghita
force-pushed
the
update-manager-providers-to-single-provider
branch
from
b880aa7 to
d6d3509
Compare
njgheorghita
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #1024
How was it fixed?
manager.providers->manager.providerweb3.providers->web3.providerCute Animal Picture