update examples and web3.eth with checksummed addresses #1390
Conversation
|
🎉 This is awesome, thank you! I did a quick search and saw that there are a bunch more in |
|
Thanks for the catches, @kclowes. I was doing this while at the vet with my dog on my lap - I shouldn't be allowed to push anything without first viewing on a bigger screen. Will get on it asap. Thanks! |
|
Hey @kclowes any idea of the the cause of those test failures? It happened with one of my earlier commits too. Later commits passed but I don't think I ever changed anything of significance that would lead to the pass/fail difference. |
There was a problem hiding this comment.
This is looking awesome, thank you! I think there are three more places that got missed:
- https://github.com/ethereum/web3.py/pull/1390/files#diff-e00a2dc1684e3f015ea142465fcce703L338
- https://github.com/ethereum/web3.py/pull/1390/files#diff-eceb1bc3115c9a285005ce4cc4ca13fdL481
- https://github.com/ethereum/web3.py/pull/1390/files#diff-eceb1bc3115c9a285005ce4cc4ca13fdL1016
Once those are in, I'll merge! I'm also happy to add them too if you're not interested, just let me know.
Tests are just flaky :( I re-ran, and it looks like they're all passing. Thanks again!
|
@kclowes thanks for the catches. It would be criminal for me to pass the last 3 fixes on to you. Should be updated in the PR now, thanks! |
|
Lol, thank you so much! This is awesome. I'll rebase and merge first thing tomorrow. Thanks again! |
ghost
deleted the
What was wrong?
Various aspects of the docs showed examples without checksummed addresses where doing so currently would throw an error.
Related to Issue #1388
How was it fixed?
I have started updating addresses in the docs to be checksummed. I haven't done a thorough review. Will do so over the next few days. If you think I'm missing something please let me know.
Cute Animal Picture