Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for release #1403

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jul 29, 2019

What was wrong?

I ran into a hiccup with the release. Needed to make some changes to setup.py

Cute Animal Picture

image

@kclowes kclowes requested review from pipermerriam and carver July 29, 2019 22:17
setup.py Outdated
"pytest-watch==4.*",
"pytest-xdist==1.*",
"pytest-watch>=4.2.0,<5.0.0",
"pytest-xdist>=1.29.0,<2.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is standardized one way or another, but lately I've been leaving off the minor/patch 0's, like: >=1.29,<2. Whichever you like better, I really don't have a strong opinion. 👍

@kclowes kclowes force-pushed the update-dependencies branch from 96a0a09 to af44b18 Compare July 31, 2019 15:43
@kclowes kclowes merged commit 0afca32 into ethereum:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants