Fix flaky parity whisper test #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
flaky-parity-test
branch
from
8bbfe13 to
bae3fd4
Compare
|
Ah, I like that better. It does feel cleaner. Thanks! |
Code0x58
approved these changes
Sep 5, 2019
Code0x58
suggested changes
Sep 5, 2019
kclowes
force-pushed
the
flaky-parity-test
branch
from
140cf6d to
0bbb46f
Compare
Code0x58
approved these changes
Sep 5, 2019
kclowes
force-pushed
the
flaky-parity-test
branch
from
0bbb46f to
1cdae8b
Compare
kclowes
force-pushed
the
flaky-parity-test
branch
from
1cdae8b to
18cf178
Compare
|
Got a verbal approval from @pipermerriam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Our parity integration tests were flaking out on the
shh.postmethod sometimes.Related to Issue #1408
How was it fixed?
Since we don't care what comes back from parity, just that we're interfacing with it correctly, added a check for an error response, and make sure it's the correct error response. Otherwise, continue with the test as usual.
Todo:
Cute Animal Picture