Type hints web3.providers #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
type-hints-providers
branch
from
2fb0269 to
fd60ca4
Compare
njgheorghita
force-pushed
the
type-hints-providers
branch
14 times, most recently
from
b023025 to
64a8a0e
Compare
njgheorghita
force-pushed
the
type-hints-providers
branch
from
64a8a0e to
be7acaf
Compare
pipermerriam
approved these changes
Nov 22, 2019
| @@ -11,6 +12,6 @@ | |||
| AUCTION_START_GAS_MARGINAL = 39000 | |||
|
|
|||
| EMPTY_SHA3_BYTES = HexBytes(b'\0' * 32) | |||
| EMPTY_ADDR_HEX = HexAddress('0x' + '00' * 20) | |||
| EMPTY_ADDR_HEX = HexAddress(HexStr('0x' + '00' * 20)) | |||
There was a problem hiding this comment.
Wouldn't this be HexAddress?
| @@ -56,7 +57,9 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| ENS_MAINNET_ADDR = ChecksumAddress(HexAddress('0x314159265dD8dbb310642f98f50C066173C1259b')) | |||
| ENS_MAINNET_ADDR = ChecksumAddress( | |||
| HexAddress(HexStr('0x314159265dD8dbb310642f98f50C066173C1259b')) | |||
There was a problem hiding this comment.
Oh, that's awkward..... that we have to do the double wrap.
There was a problem hiding this comment.
Yeah, I can't say I'm a huge fan. It'll probably be somewhat confusing/frustrating to devs as it breaks their mypys - at least initially, until they get used to the convention. But, I'm not so sure the awkwardness is worth relaxing the HexAddress back to str?
njgheorghita
force-pushed
the
type-hints-providers
branch
from
6ece7a9 to
645085d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Finish type hinting
web3.providersCute Animal Picture