Update ipfshttpclient #1775
Merged
Update ipfshttpclient #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Looks good to me! just one missing thing is to rollback the docstring from python back to doctest here
| @@ -45,7 +44,6 @@ def test_get_resolvable_backends_for_supported_uris(uri, backends): | |||
| ), | |||
| ) | |||
| @pytest.mark.skipif('WEB3_INFURA_PROJECT_ID' not in os.environ, reason='Infura API key unavailable') | |||
| @pytest.mark.xfail(reason="py-ipfs-http-client library doesn't support go-ipfs v0.7.0") | |||
| def test_get_translatable_backends_for_supported_uris(uri, backends): | |||
There was a problem hiding this comment.
I guess it doesn't make a difference to the test passing, but maybe we want to add the dummy_ipfs_backend back in the args here like it was before
|
Aha, good memory! thank you! |
kclowes
force-pushed
the
update-ipfshttpclient
branch
from
8e9e3f7 to
3db3d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The
ipfshttpclientpackage updated, and now our tests can pass again!How was it fixed?
Updated, but not sure if pinning to the alpha version is any better. If it's not better, I can close this PR until it's out of pre-release. I pinned instead of providing a range because it sounds like there will be breaking changes still.
Todo:
Cute Animal Picture