Remove module #1805
Merged
Remove module #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
remove-module
branch
from
5b16635 to
30662c6
Compare
kclowes
force-pushed
the
remove-module
branch
3 times, most recently
from
e88feb1 to
4414393
Compare
wolovim
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Out with the old, in with the new! Got rid of the last
Modulereferences, in favor ofModuleV2which supports async. The next PR, I'll change the ModuleV2 to Module, since it no longer makes sense to have it versioned any more.I debated putting the attach_modules function on the web3 class, and ultimately decided to keep it in _utils/module. If anyone has a strong opinion one way or the other, I will happily move it!
Todo:
Cute Animal Picture