Eth Default Account property to snake case #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
default-acct-snake
branch
from
e977064 to
790c73a
Compare
kclowes
force-pushed
the
default-acct-snake
branch
from
790c73a to
4de387a
Compare
1 task
wolovim
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Adds a
default_accountproperty to the Eth module, and deprecatesdefaultAccount.Related to Issue #1429
How was it fixed?
Thanks to @billbsing for the PR. I just split out the original PR for reviewability and got it up to date with the current master.
Todo:
Cute Animal Picture