Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth 1.10.5 fixture update #2073

Merged
merged 1 commit into from
Jul 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ geth_steps: &geth_steps
name: build geth if missing
command: |
mkdir -p $HOME/.ethash
pip install --user py-geth>=3.2.0
pip install --user py-geth>=3.3.0
export GOROOT=/usr/local/go
echo $GETH_VERSION
export GETH_BINARY="$HOME/.py-geth/geth-$GETH_VERSION/bin/geth"
Expand Down Expand Up @@ -287,23 +287,23 @@ jobs:
- image: circleci/python:3.6
environment:
TOXENV: py36-integration-goethereum-ipc
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py36-integration-goethereum-http:
<<: *geth_steps
docker:
- image: circleci/python:3.6
environment:
TOXENV: py36-integration-goethereum-http
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py36-integration-goethereum-ws:
<<: *geth_steps
docker:
- image: circleci/python:3.6
environment:
TOXENV: py36-integration-goethereum-ws
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

# py36-integration-parity-ipc:
# <<: *parity_steps
Expand Down Expand Up @@ -379,23 +379,23 @@ jobs:
- image: circleci/python:3.7
environment:
TOXENV: py37-integration-goethereum-ipc
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py37-integration-goethereum-http:
<<: *geth_steps
docker:
- image: circleci/python:3.7
environment:
TOXENV: py37-integration-goethereum-http
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py37-integration-goethereum-ws:
<<: *geth_steps
docker:
- image: circleci/python:3.7
environment:
TOXENV: py37-integration-goethereum-ws
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

# py37-integration-parity-ipc:
# <<: *parity_steps
Expand Down Expand Up @@ -476,23 +476,23 @@ jobs:
- image: circleci/python:3.8
environment:
TOXENV: py38-integration-goethereum-ipc
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py38-integration-goethereum-http:
<<: *geth_steps
docker:
- image: circleci/python:3.8
environment:
TOXENV: py38-integration-goethereum-http
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py38-integration-goethereum-ws:
<<: *geth_steps
docker:
- image: circleci/python:3.8
environment:
TOXENV: py38-integration-goethereum-ws
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

# py38-integration-parity-ipc:
# <<: *parity_steps
Expand Down Expand Up @@ -568,23 +568,23 @@ jobs:
- image: circleci/python:3.9
environment:
TOXENV: py39-integration-goethereum-ipc
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py39-integration-goethereum-http:
<<: *geth_steps
docker:
- image: circleci/python:3.9
environment:
TOXENV: py39-integration-goethereum-http
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

py39-integration-goethereum-ws:
<<: *geth_steps
docker:
- image: circleci/python:3.9
environment:
TOXENV: py39-integration-goethereum-ws
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

# py39-integration-parity-ipc:
# <<: *parity_steps
Expand Down Expand Up @@ -634,7 +634,7 @@ jobs:
- image: circleci/python:3.9
environment:
TOXENV: benchmark
GETH_VERSION: v1.10.4
GETH_VERSION: v1.10.5

workflows:
version: 2.1
Expand Down
4 changes: 2 additions & 2 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -309,13 +309,13 @@ Geth Fixtures

.. code:: sh

$ python -m geth.install v1.10.4
$ python -m geth.install v1.10.5

2. Specify the Geth binary and run the fixture creation script (from within the web3.py directory):

.. code:: sh

$ GETH_BINARY=~/.py-geth/geth-v1.10.4/bin/geth python ./tests/integration/generate_fixtures/go_ethereum.py ./tests/integration/geth-1.10.4-fixture
$ GETH_BINARY=~/.py-geth/geth-v1.10.5/bin/geth python ./tests/integration/generate_fixtures/go_ethereum.py ./tests/integration/geth-1.10.5-fixture

3. The output of this script is your fixture, a zip file, which is now stored in ``/tests/integration/``.
Update the ``/tests/integration/go_ethereum/conftest.py`` file to point to this new fixture. Delete the old fixture.
Expand Down
1 change: 1 addition & 0 deletions newsfragments/2073.misc.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support for geth v1.10.5
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
extras_require = {
'tester': [
"eth-tester[py-evm]==v0.5.0-beta.4",
"py-geth>=3.2.0,<4",
"py-geth>=3.3.0,<4",
],
'linter': [
"flake8==3.8.3",
Expand All @@ -21,7 +21,7 @@
"click>=5.1",
"configparser==3.5.0",
"contextlib2>=0.5.4",
"py-geth>=3.2.0,<4",
"py-geth>=3.3.0,<4",
"py-solc>=0.4.0",
"pytest>=4.4.0,<5.0.0",
"sphinx>=3.0,<4",
Expand Down
Binary file removed tests/integration/geth-1.10.4-fixture.zip
Binary file not shown.
Binary file added tests/integration/geth-1.10.5-fixture.zip
Binary file not shown.
2 changes: 1 addition & 1 deletion tests/integration/go_ethereum/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

KEYFILE_PW = 'web3py-test'

GETH_FIXTURE_ZIP = 'geth-1.10.4-fixture.zip'
GETH_FIXTURE_ZIP = 'geth-1.10.5-fixture.zip'


@pytest.fixture(scope='module')
Expand Down
2 changes: 1 addition & 1 deletion web3/tools/benchmark/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
kill_proc_gracefully,
)

GETH_FIXTURE_ZIP = "geth-1.10.4-fixture.zip"
GETH_FIXTURE_ZIP = "geth-1.10.5-fixture.zip"


class GethBenchmarkFixture:
Expand Down