Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format receipt.type to int and log.data to HexBytes #2488

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented May 26, 2022

What was wrong?

Related to Issue #2482

How was it fixed?

Added/updated formatters for log entries and receipts

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the receipt-formatting branch from a08b95a to f3bef3b Compare May 26, 2022 17:53
@pacrob pacrob force-pushed the receipt-formatting branch from f3bef3b to 69fca18 Compare May 26, 2022 18:07
@pacrob pacrob requested review from fselmo and kclowes and removed request for fselmo May 26, 2022 18:16
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pacrob pacrob merged commit dbe0801 into ethereum:master Jun 1, 2022
@pacrob pacrob deleted the receipt-formatting branch June 1, 2022 19:20
@martin-thoma
Copy link

This was a breaking change for me. It is not listed as a breaking change in the docs, though.

@pacrob
Copy link
Contributor Author

pacrob commented Apr 7, 2023

This was a breaking change for me. It is not listed as a breaking change in the docs, though.

Thanks for the note, @MT-Cash - I've added those changes to the v6 migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants