Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add txn result formatters for type and chainId #2506

Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Jun 7, 2022

What was wrong?

closes #2491

How was it fixed?

  • Add transaction result formatters for type and chainId to convert values to int if hexadecimal if the field is not null

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo requested review from pacrob and kclowes June 7, 2022 22:06
- Add transaction result formatters for `type` and `chainId` to convert from values to ``int`` if  ``hexadecimal`` if the field is not null
@fselmo fselmo force-pushed the additional-breaking-transaction-formatters branch from 4c1d789 to a861ae0 Compare June 7, 2022 22:07
@fselmo fselmo changed the title Add txn result formatters for type and chainId Add txn result formatters for type and chainId Jun 7, 2022
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit 6945072 into ethereum:master Jun 8, 2022
@fselmo fselmo deleted the additional-breaking-transaction-formatters branch June 8, 2022 21:21
@fselmo fselmo restored the additional-breaking-transaction-formatters branch June 8, 2022 21:21
@fselmo fselmo deleted the additional-breaking-transaction-formatters branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected types for transaction fields
2 participants