Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6] Update integration test fixture to use geth v1.10.23 #2630

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Sep 6, 2022

What was wrong?

Update integration test suite to use geth v1.10.23 since newly-released py-geth version 3.9.1 makes this available

Todo:

Cute Animal Picture

20220904_155343

@fselmo fselmo force-pushed the v6-update-fixture-use-1.10.23 branch from 1e5bcd3 to 58bfa06 Compare September 6, 2022 20:53
@fselmo
Copy link
Collaborator Author

fselmo commented Sep 6, 2022

Looking into flaky Timeout issues again with the offchain lookup test suite... putting this on hold for review for now until that's resolved

@fselmo fselmo marked this pull request as ready for review September 7, 2022 17:11
@fselmo fselmo requested review from kclowes and pacrob September 7, 2022 17:11
@fselmo
Copy link
Collaborator Author

fselmo commented Sep 7, 2022

Looks like circleCI had some issues yesterday... all looks to be passing consistently today. Ready for review 👀

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 !

@fselmo fselmo merged commit bf8e046 into ethereum:master Sep 7, 2022
@ofek ofek mentioned this pull request Sep 11, 2022
@fselmo fselmo deleted the v6-update-fixture-use-1.10.23 branch April 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants