Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal apply_formatters_to_array #2737

Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 23, 2022

What was wrong?

How was it fixed?

  • Remove web3.py's apply_formatter_to_array and use the eth-utils method with the same name instead.

Todo:

Cute Animal Picture

n621963065_1604526_454

- Remove web3.py ``apply_formatter_to_array`` and use the method with the same name from eth-utils
@fselmo fselmo force-pushed the standardize-apply-formatters-to-array branch from 5e2723c to 56f94f4 Compare November 23, 2022 19:35
@fselmo fselmo marked this pull request as ready for review November 23, 2022 19:37
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fselmo fselmo merged commit 8f9065c into ethereum:master Nov 28, 2022
@fselmo fselmo deleted the standardize-apply-formatters-to-array branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize apply_formatter_to_array
2 participants