Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async eth.sign_transaction #2848

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Add async eth.sign_transaction #2848

merged 1 commit into from
Apr 7, 2023

Conversation

Player256
Copy link
Contributor

@Player256 Player256 commented Feb 24, 2023 •
edited by kclowes
Loading

What was wrong?

Closes #2827

How was it fixed?

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@Player256 Player256 changed the title Added async eth.sign_transaction Add async eth.sign_transaction Feb 25, 2023
@Player256
Copy link
Contributor Author

@kclowes

kclowes
kclowes reviewed Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and the ping! Looks like there are some lint errors to clean up, and I made a comment on the line where the go-ethereum tests are breaking. Let me know if you want me to make those fixes!

web3/_utils/module_testing/eth_module.py Outdated Show resolved Hide resolved
@sujantkumarkv sujantkumarkv mentioned this pull request Mar 12, 2023
Closed
@kclowes
Copy link
Collaborator

kclowes commented Mar 13, 2023

I'll take another look once we get v6 stable out. Thanks!

kclowes
kclowes approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Player256! I fixed the failing tests and added a few more.

@kclowes kclowes merged commit 402d001 into ethereum:master Apr 7, 2023
@kclowes kclowes mentioned this pull request Apr 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add async eth.sign_transaction
2 participants
@Player256 @kclowes