Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cleanup quickstart #2935

Merged
merged 1 commit into from
Apr 26, 2023
Merged

docs: cleanup quickstart #2935

merged 1 commit into from
Apr 26, 2023

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Apr 25, 2023 •
edited
Loading

What was wrong?

  • warnings for the async provider are no longer necessary, imo
  • listing example node providers is an exercise in futility/invitation for all of them to submit PRs to be included in that list. we can outsource that to eth.org.
  • suggested next steps after reading this page needed tightening up a bit. added bullet points.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@wolovim wolovim force-pushed the docs-quickstart-cleanup branch from f888f40 to 1b84e18 Compare April 25, 2023 21:47
kclowes
kclowes approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wolovim wolovim merged commit 655ee37 into ethereum:main Apr 26, 2023
@wolovim wolovim deleted the docs-quickstart-cleanup branch April 26, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolovim @kclowes