Test to catch if files are missing from a release #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
bugfix-wheel-tests
branch
14 times, most recently
from
eda0848 to
3d41af1
Compare
kclowes
force-pushed
the
bugfix-wheel-tests
branch
2 times, most recently
from
ce7dcaa to
f92ce28
Compare
kclowes
force-pushed
the
bugfix-wheel-tests
branch
from
f92ce28 to
1913edf
Compare
reedsa
reviewed
Jul 18, 2023
| @@ -0,0 +1,7 @@ | |||
| rm -rf build dist | |||
There was a problem hiding this comment.
Recommend using #!/bin/bash for the script. Can also use set -e to exit on error if that's useful.
Not sure what the equivalent is for windows, maybe it also follows some best practices.
pacrob
approved these changes
Jul 18, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
v6.6.0was missing a few new, required, files in the release. The wheel tests should catch this, but they didn't this time.How was it fixed?
Now the built files get installed in a new temporary directory and a separate virtualenv so that the dist files don't pick up the files that were present after the circleci code check out.
Todo:
Cute Animal Picture