Run flaky eth-tester tests #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
eth-tester-flaky
branch
2 times, most recently
from
875d360 to
2a9abdf
Compare
kclowes
force-pushed
the
eth-tester-flaky
branch
from
c66f218 to
d600678
Compare
kclowes
force-pushed
the
eth-tester-flaky
branch
from
d600678 to
d1b74d2
Compare
fselmo
reviewed
Dec 4, 2023
| "to": revert_contract.address, | ||
| }, | ||
| ) | ||
| with pytest.raises(TransactionFailed, match="execution reverted"): |
There was a problem hiding this comment.
We should check the messages on the "with message" cases, right?
There was a problem hiding this comment.
Yeah, that's a good idea. Updated!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth-tester tests that utilize the
unlocked_account{...}fixtures weren't being run.How was it fixed?
Added tests to CI and updated the expectations. Also standardized
xfails using thenot_implementedmethodl, so any tests that are expected to fail are not using thenot_implementedmethod.Todo:
Cute Animal Picture