Raise exceptions by default; opt to silence in message listener task #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
raise-listener-task-exceptions-by-default
branch
from
3e83607 to
1615a97
Compare
|
Update looks good, but I don't see any reference to this option in docs. Is that coming separately, or should be added here? |
fselmo
force-pushed
the
raise-listener-task-exceptions-by-default
branch
from
10fda00 to
18a632a
Compare
|
@pacrob I added a more extensive update of the docs here since it was stale. Thanks for the poke. Take a look again and lmk if anything looks off. I also took the |
- Remove the ``endpoint_uri`` argument from the ``PersistentConenctionProvider`` base class, opting for defining it in the inheriting classes instead. - Update the documentation around the ``WebsocketProviderV2`` class to reflect the current state + document ``PersistentConenctionProvider`` under a new section.
fselmo
force-pushed
the
raise-listener-task-exceptions-by-default
branch
from
18a632a to
d3bab44
Compare
fselmo
added a commit
to fselmo/web3.py
that referenced
this pull request
Jan 25, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
It is often best to fail hard and fast and be able to silence exceptions rather than let exceptions possibly go unnoticed. We were defaulting to silencing exceptions in the message listener task for
WebsocketProviderV2. This hasn't been released yet and so this change just aims to tweak the configuration and opt to silence exceptions that are raised by default.How was it fixed?
raise_listener_task_exceptions->silence_listener_task_exceptionsTodo:
Cute Animal Picture