Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptive Event ABI Error Messages #3453

Closed
wants to merge 2 commits into from

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Aug 19, 2024

What was wrong?

Closes #964

A Web3ValueError is raised by get_event_abi if a match is not found. This error is not very useful, but could include more information. get_element_abi returns a meaningful exception message which lists the arguments and potential matches.

How was it fixed?

Raise the same MismatchedABI exception from get_event_abi.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa requested review from fselmo, kclowes and pacrob August 19, 2024 19:57
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@reedsa
Copy link
Contributor Author

reedsa commented Aug 22, 2024

In the context of https://github.com/ethereum/web3.py/pull/3457/files, exception messages will be raised in cases where the "event" ABI is not matched. Instead of merging this, I'll apply the message updates in the other PR.

@reedsa reedsa closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messages on mismatched argument types
2 participants