EIP 140: adding REVERT instruction #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Feb 22, 2017
| @@ -898,7 +908,7 @@ \subsubsection{Exceptional Halting} | |||
| \end{array} | |||
| \end{equation} | |||
|
|
|||
| This states that the execution is in an exceptional halting state if there is insufficient gas, if the instruction is invalid (and therefore its $\delta$ subscript is undefined), if there are insufficient stack items, if a {\small JUMP}/{\small JUMPI} destination is invalid or the new stack size would be larger then 1024. The astute reader will realise that this implies that no instruction can, through its execution, cause an exceptional halt. | |||
| This states that the execution is in an exceptional halting state if there is insufficient gas, if the instruction is invalid (and therefore its $\delta$ subscript is undefined), if there are insufficient stack items, if a {\small JUMP}/{\small JUMPI} destination is invalid or the new stack size would be larger then 1024. | |||
There was a problem hiding this comment.
Unrelated to this change, but perhaps worth mentioning that:
if the instruction is invalid (including {\small INVALID}...
axic
reviewed
Feb 22, 2017
| @@ -767,14 +772,19 @@ \section{Message Call} \label{ch:call} | |||
| \end{cases} | |||
| \end{equation} | |||
|
|
|||
| The account's associated code (identified as the fragment whose Keccak hash is $\boldsymbol{\sigma}[c]_c$) is executed according to the execution model (see section \ref{ch:model}). Just as with contract creation, if the execution halts in an exceptional fashion (i.e. due to an exhausted gas supply, stack underflow, invalid jump destination or invalid instruction), then no gas is refunded to the caller and the state is reverted to the point immediately prior to balance transfer (i.e. $\boldsymbol{\sigma}$). | |||
| The account's associated code (identified as the fragment whose Keccak hash is $\boldsymbol{\sigma}[c]_c$) is executed according to the execution model (see section \ref{ch:model}). Just as with contract creation, if the execution halts in an exceptional fashion (i.e. due to an exhausted gas supply, stack underflow, invalid jump destination or invalid instruction), then no gas is refunded to the caller and the state is reverted to the point immediately prior to balance transfer (i.e. $\boldsymbol{\sigma}$). However, if the execution halted by a {\small REVERT} instruction, the remaining gas (if any) is paid back although the state is reverted. | |||
There was a problem hiding this comment.
Maybe we could have a proper list of "exceptional halts" somewhere.
pirapira
changed the title
|
I just realized that, I still need to update the way CALL calculates its return value. Currently it just uses the exceptional halting function |
Closed
pirapira
changed the title
|
I fixed the return values of |
|
@gavofyork 's suggestion was to implement this as another clause in the definition of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request implements ethereum/EIPs#206 . Merging this requires the community's consensus on the EIP.
Fixes #232