-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECIP-1083: Remove Contract Size Limit #249
Conversation
Signed-off-by: meows <[email protected]>
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Zachary,
I think the only thing holding this up from being merged is that WIP is not a valid status.
Should be "Draft".
Why don't you make that edit, and we get this merged?
It is an important area for consideration.
@bobsummerwill to my understanding a WIP PR can be merged in that status as an ECIP as per ECIP-1000:
|
Right you are, @tokenhash! I was not aware of that status. |
needs 1 more editor approval, and I dont think self-approval is appropriate. bump @whilei |
WIP shouldn't be merged as the P stands for progress. something in progress cannot be proposed. please proceed to draft stage once you want to propose something and are confident this is a good first draft. |
Makes sense. If that is the case, then I am going to adjust ECIP-0001 to show WIP can be entered as PRs, but can only advance to merged only if they are stable drafts. |
@bobsummerwill @BelfordZ @soc1c I added/modified this text on ECIP-0001 to reflect the WIP rule:
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can approve it, but first it needs a License unless you specified it somewhere. |
Co-Authored-By: meowsbits <[email protected]>
isnt the default license of apache 2.0 assumed when no license is provided? |
https://ecips.ethereumclassic.org/ECIPs/ecip-1000#ecip-licensing
|
status: Draft | ||
type: Standards Track | ||
category: Core | ||
created: 2019-12-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created: 2019-12-20 | |
created: 2019-12-20 | |
license: Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
"isnt the default license of apache 2.0 assumed when no license is provided?" There is no default license. We never added a root license. IP protection is still TODO. |
ref: ethereum/EIPs#1662 ethereum/EIPs#170