This repository has been archived by the owner on Apr 6, 2020. It is now read-only.
Replace uses of deprecated new Buffer with Buffer.from
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed -i.bak 's/new Buffer/Buffer.from/' *.js test/*.js && \
find . -name '*.bak' -delete
holgerd77
approved these changes
Dec 7, 2018
axic
reviewed
Dec 7, 2018
|
This should not be needed any more since we have dropped Node 4 (and 5) support with EOL being reached. |
|
Didn't know that. Does it make sense removing that workaround from the codebase then? |
|
@axic yup, |
|
Have opened a PR ethereumjs/organization#45 to add a note on this to the docs, together with an additional table on Node.js distribution version support, @whymarrh can you directly do a review on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also ethereumjs/ethereumjs-blockchain#80
This PR removes usages of the deprecated
new BufferAPI.