-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
2cbb2a0
to
041836a
Compare
04939f1
to
2d25bf7
Compare
@s1na @krzkaczor Hmm, I have now |
@holgerd77 is there a possibility that you run an old version of common prettier config package? Maybe I am not sure if you can SSH to travis CI but this would also be a good idea (you def can do this on circeci). |
@krzkaczor Hmm, have also done (reinstall node modules). |
@holgerd77 I had also faced this, but wasn't sure what's the cause. Just tried it in your branch and the same happens for me. Interestingly if you run |
@s1na Works! ✨ Thanks! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There were just a few minor comments.
Another point: on Common
class, return type annotations for the methods before hardforkBlock
have probably been forgotten 😄
Have updated the missing return values. |
@s1na Hi Sina, just pushed, can you have another look and approve if you are satisfied with everything? |
TypeScript transition based on the initial work on the RLP library ethereumjs/rlp#37.