Remove fakeBlockchain class and associated tests #466
Conversation
holgerd77
force-pushed
the
remove-fake-blockchain
branch
from
b5e9960 to
30eec59
Compare
| @@ -39,6 +39,7 @@ | |||
| "async-eventemitter": "^0.2.2", | |||
| "ethereumjs-account": "^2.0.3", | |||
| "ethereumjs-block": "~2.2.0", | |||
| "ethereumjs-blockchain": "^3.4.0", | |||
There was a problem hiding this comment.
Could this have been the reason for using fakeBlockchain? To avoid depending on ethereumjs-blockchain maybe?
Did you face any roadblocks when dropping the fake blockchain?
There was a problem hiding this comment.
Already wondered if browser compatibility would be the reason for this, maybe we should get some more of the Karma tests running before proceeding here?
There was a problem hiding this comment.
Yeah, better safe than sorry. Will work on the karma tests now.
lib/index.js
Outdated
| @@ -65,7 +65,7 @@ function VM (opts = {}) { | |||
| this.stateManager = new StateManager({ trie, common: this._common }) | |||
| } | |||
|
|
|||
| this.blockchain = opts.blockchain || fakeBlockchain | |||
| this.blockchain = opts.blockchain || new Blockchain({ common: this._common }) | |||
There was a problem hiding this comment.
Just for clarification: since the db parameter is not provided, Blockchain will create an in-memory leveldb instance to store blocks and their metadata.
holgerd77
force-pushed
the
remove-fake-blockchain
branch
from
30eec59 to
813b10e
Compare
|
Rebased this, I would then merge if checks pass. |
…VM with Blockchain instance as default
holgerd77
force-pushed
the
remove-fake-blockchain
branch
from
813b10e to
b5ca279
Compare
|
Rebased this. |
|
@s1na Can you re-approve here? |
See #446 for follow-up on discussion, also part of #449 and #455.