Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vm to evm, move precompiles to evm module #481

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Mar 22, 2019

See #455 for discussion

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.126% when pulling a792437 on rename-evm into 74eabba on master.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@axic
Copy link
Member

axic commented Apr 12, 2019

I'd actually argue that precompiles are part of the client and not the VM, but it may make sense this way if you plan to have wasm-based precompiles.

@s1na
Copy link
Contributor Author

s1na commented Apr 12, 2019

if you plan to have wasm-based precompiles

Yeah that was the main reasoning.

I'd actually argue that precompiles are part of the client and not the VM

I think I see your point and different precompiles (regardless of vm-type) would be distinguished by their address (i.e. there's no need to separate them based on vm-type). This was mostly a relocation of the precompile files in the directory structure, and doesn't affect the logic in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants