This repository has been archived by the owner on Jan 11, 2022. It is now read-only.
Add test for issue#35 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzkaczor
approved these changes
Nov 14, 2018
|
@GrandSchtroumpf Thanks for integrating this, great! 😄 One small suggestion: better to make commit messages self-descriptive than to reference the issue (e.g. "Add test for recursive typings"), this will otherwise be pretty meaningless and hard to decipher when going through the commit history. |
|
ok. Thanks for the advice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try, this time I based it on the current merged
typescriptbranch.