This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
Show help and exit on invalid command. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution: create cli.App.CommandNotFound method and manually check against existing commands (patch) fixes ethereumproject#190
splix
approved these changes
Apr 21, 2017
solution: write bats test for expected cli behavior
solution: increase sleep time for pending io
solution: increase the time
solution: more time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show help, exit code 3 (congruent to cli package) if geth receives an unknown command, ie
geth verison.I'm not sure why urfave/cli does catch unknown
--flags, but doesn't catch unknowncommands. In that light, I consider this a patch.Fixes #190