1.4.11 stable #37
1.4.11 stable #37
Conversation
|
I gave up on trying to get all the tests working on the most up-to-date version, so I applied the memory-leak patch to the last stable release. If @whatisgravity returns, or if someone else wants to take a stab at it, we can merge all the subsequent changes back in, but right now we should have a build release that passes all the tests. |
There was a problem hiding this comment.
I can only confirm that this patch is equal to the corresponding fix in forked ethereum (commit ethereum/go-ethereum@e44b2dc)
As it didn't make any problems to ETH users, it's safe to merge in our codebase
|
I'd like to send this straight to a release. I don't see the point of merging it into develop since develop is currently unstable. |
|
@elaineo ok, that's probably a good idea |
|
I don't see an issue merging to develop. This change doesnt affect anything currently out of sync in develop. We can cherry pick the commit like arachnid suggested to master and promote into a release that way while still retaining the fix in develop in case we decide to stick with develop branch |
* Replace repository reference for accounts/abi/bind (#29) * docs: update badges (#34) * docs: add gitter badge * docs: add circle-ci badge * Update README.md * Update README.md * Update README.md * docs: update repository path * Update README.md * Tx Encoding and decoding fix (#33) * Added test for decoding old encoding function * Fixed decoding issue and improved tests to handle all cases including previous client * Add compatibility with previous version * Rename receipt storage variable * Storage and edge case fixes (#28) * Applied storage fixes and updates * Minor execution refactor
Trying to get a clean build to work from.
The only change since 1.4.10 is the ETH hotfix to fix the memory leak, with added comments to the best of my ability
Also removed the dao_test so all tests pass.