This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
Fix vendoring issues #570
Merged
Fix vendoring issues #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solution: temporary switch to forked branch with proposed PR with code that we require. After fatih/color#87 is merged, we can switch to original repository.
r8d8
approved these changes
Apr 26, 2018
whilei
reviewed
Apr 26, 2018
| # TODO(tzdybal): monitor https://github.com/fatih/color/pull/87 | ||
| source = "github.com/achilleas-k/color" | ||
| branch = "expose-colorised-stderr" |
There was a problem hiding this comment.
Is contraining to branch ok? Or maybe tag or commit hash would be more solid?
There was a problem hiding this comment.
Remember about Gopkg.lock file - it stable until explicit call to dep update. And this is temporary solution anyways.
There was a problem hiding this comment.
Ah, just noticed
solution: temporary switch to forked branch with proposed PR
with code that we require. After fatih/color#87
is merged, we can switch to original repository.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for
fatih/color(I'm subscribed to the PR, I'll switch to master repository after PR is merged)and sputnikvm-ffi problems.
Sources in
vendorwas not in sync withGopkg.lock, and this was a root cause of the issue.