Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is lacking for manually ABI-encoding structs #1147

Closed
nventuro opened this issue Nov 11, 2020 · 2 comments
Closed

Documentation is lacking for manually ABI-encoding structs #1147

nventuro opened this issue Nov 11, 2020 · 2 comments
Labels
documentation Documentation related issue.

Comments

@nventuro
Copy link

Hi! The ABI encoder works fantastic for Solidity contracts with functions that receive structs (though error diagnosis and reporting could be better when a field is missing 😅), but I couldn't find much info in using this machinery to manually ABI-encode a struct.

The documentation doesn't provide any examples on how to do this, and while this Google-able comment shows encoding of a tuple, I couldn't find the equivalent for structs.

Given protocols are becoming more complex and configurable, and that a solution for stack-too-deep doesn't seem to be coming anytime soon, memory structs seem like the way to go for most projects, and better support for them would be extremely helpful. Thanks!

@ricmoo ricmoo added the documentation Documentation related issue. label Nov 12, 2020
@ricmoo
Copy link
Member

ricmoo commented Feb 17, 2021

The PR for #1302 will address this, and the discussion #1301 will help too.

@ricmoo
Copy link
Member

ricmoo commented Aug 9, 2021

Added some examples.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue.
Projects
None yet
Development

No branches or pull requests

2 participants