removeAllListeners throws error

[nionis]

Hello everybody!

I have encountered this issue when running:

provider.removeAllListeners()
myContract.removeAllListeners()

Error: invalid event - null
    at getEventTag (/somepath/node_modules/@ethersproject/providers/src.ts/base-provider.ts:102:11)
    at WebSocketProvider.BaseProvider.off (/somepath/node_modules/@ethersproject/providers/src.ts/base-provider.ts:1569:24)
    at Contract.BaseContract._checkRunningEvents (/somepath/node_modules/@ethersproject/contracts/src.ts/index.ts:921:31)
    at Contract.BaseContract.removeAllListeners (/somepath/node_modules/@ethersproject/contracts/src.ts/index.ts:1066:22)
    at Indexer.stop (/somepath/packages/core-ethereum/src/indexer/index.ts:118:41)
    at /somepath/packages/core-ethereum/src/index.ts:106:32

the relevant code looks like this:

    // subscribe to new blocks
    provider
      .on('block', (blockNumber: number) => {
        this.onNewBlock({ number: blockNumber })
      })
      .on('error', (error: any) => {
        log(chalk.red(`etherjs error: ${error}`))
        this.restart()
      })

    // subscribe to all events
    myContract
      .on('*', (event: Event<any>) => {
        this.onNewEvents([event])
      })
      .on('error', (error: any) => {
        log(chalk.red(`etherjs error: ${error}`))
        this.restart()
      })

[ricmoo]

This has been addressed in 5.1.2. Try it out and let me know if there are any more issues.

[nionis]

@ricmoo looks good over here, thanks!

[ricmoo]

Awesome! Glad to hear it. :)

Thanks! :)