Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp not present for getHistory in the Etherscan Provider #174

Closed
itsyogesh opened this issue Apr 29, 2018 · 2 comments
Closed

Timestamp not present for getHistory in the Etherscan Provider #174

itsyogesh opened this issue Apr 29, 2018 · 2 comments
Labels
discussion Questions, feedback and general information.

Comments

@itsyogesh
Copy link

Hi,

Before I begin I just wanted to say this library is amazing. On with the issue, I am using the .getHistory() function with the Etherscan provider, but the timestamp is not included in the transaction object. I was going through the source, and there is a checkTransaction function that checks and formats the API. Any thoughts on how I can implement this, or should I add this in a PR.
@itsyogesh itsyogesh changed the title Timestamp not present for getHistory in the etherscan Timestamp not present for getHistory in the Etherscan Provider Apr 29, 2018
@ricmoo ricmoo added investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. labels May 13, 2018
ricmoo added a commit that referenced this issue May 14, 2018
@ricmoo
Added timestamp to EtherscanProvider history (#174).
3cb21dd
@ricmoo ricmoo added discussion Questions, feedback and general information. and removed investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. labels May 14, 2018
@ricmoo
Copy link
Member

ricmoo commented May 14, 2018

Added and published to npm. :)

@ricmoo ricmoo closed this as completed May 14, 2018
@itsyogesh
Copy link
Author

Hey @ricmoo
Thanks a lot for this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Questions, feedback and general information.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @itsyogesh