Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listAccounts() returns a promise #1851

Closed
jrfrantz opened this issue Aug 9, 2021 · 2 comments
Closed

listAccounts() returns a promise #1851

jrfrantz opened this issue Aug 9, 2021 · 2 comments
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@jrfrantz
Copy link

jrfrantz commented Aug 9, 2021

JsonRpcProvider docs say that listAccounts() method returns an array of strings (link). This is almost correct -- it technically returns a Promise that resolves to an array of strings.

You can verify in the code here
@jrfrantz jrfrantz added the documentation Documentation related issue. label Aug 9, 2021
@ricmoo
Copy link
Member

ricmoo commented Aug 9, 2021

Good catch! Thanks! :)

@ricmoo ricmoo added the on-deck This Enhancement or Bug is currently being worked on. label Aug 9, 2021
ricmoo added a commit that referenced this issue Aug 9, 2021
@ricmoo
docs: Fix listAccounts return type (#1851).
1b4bc7a
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Aug 9, 2021
@ricmoo
Copy link
Member

ricmoo commented Aug 9, 2021

Fixed and published.

Thanks! :)

@ricmoo ricmoo closed this as completed Aug 9, 2021
@snyk-bot snyk-bot mentioned this issue Sep 8, 2021
Open
This was referenced Sep 18, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricmoo @jrfrantz