JsonRpcSigner.prototype.sendTransaction fails with "invalid key - from"

[mschristensen]

The sendTransaction method on an JsonRpcSigner instance (from the getSigner method) appears to be broken:

Error: invalid key - from (argument="transaction", value=...

The from key should not be required, and seems to be set up incorrectly by the signer.

Can anyone else reproduce, or alternatively provide a working example?

Example usage:

await web3Provider.getSigner().sendTransaction({
        to: ethAddress,
        value: ethers.utils.parseEther(this.amountToEther()),
});

[ricmoo]

I’ll look into this today. Probably related to a fix put in yesterday; the from is added internally for calling estimateGas.

Can you try explicitly adding a gasLimit to the transaction?

[ricmoo]

I found the problem. I will be doing a small re-factor too which will fix this and make it easier for Signer authors.

We also need a way to run regression tests against a node with accounts; this should have been caught in a test case. Sorry. :(

In the future we will be able to use ethers-vm for better testing.

[ricmoo]

A fix for this (along with tests in tests/local-tests.js) has been deployed in version 4.0.7. Please try it out and let me know if you have any issues. I'll leave the issue open a bit longer to verify the fix worked.

[ricmoo]

I'm going to close this now, but if you are still experiencing issues, please feel free to re-open.

Thanks! :)

[mschristensen]

Can confirm this is fixed. Thanks for doing this promptly!