Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove console.log line in browser-random-bytes #36

Closed
kabriel opened this issue Sep 20, 2017 · 4 comments
Closed

Remove console.log line in browser-random-bytes #36

kabriel opened this issue Sep 20, 2017 · 4 comments

Comments

@kabriel
Copy link

kabriel commented Sep 20, 2017

ethers.js/utils/browser-random-bytes.js

Line 25 in c566f00

console.log('Found strong random number source');

@ricmoo
Copy link
Member

ricmoo commented Oct 20, 2017

Is there a specific reason why this should be removed?

It should maybe be the other direction; warning if there is no strong crypto found. Hmm...

@kabriel
Copy link
Author

kabriel commented Oct 20, 2017

It is generally expected that libraries will not be chatty other than for warnings/errors, such as 'no strong crypto found' like you suggest.

@ricmoo
Copy link
Member

ricmoo commented Oct 20, 2017

Fair enough. I will add that shortly. :)

ricmoo added a commit that referenced this issue Oct 20, 2017
@ricmoo
Removed chatty library (See issue #36).
5c776a8
@ricmoo
Copy link
Member

ricmoo commented Oct 21, 2017

Fixed in 5c776a8.

Also, rebuilt the dist files. I will update the CDN this evening.

@ricmoo ricmoo closed this as completed Oct 21, 2017
@jackromo888 jackromo888 mentioned this issue Sep 30, 2022
Open
@Woodpile37 Woodpile37 mentioned this issue Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kabriel @ricmoo