fix: handle auth and server error during swap #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐝 PR preview in SwarmPreview URL: https://bah5acgzabqbnwqob5ozvrplcb6ncfg54etjgnx2fuu5fut4jqisj47i7b42q.bzz.link |
AuHau
approved these changes
Dec 1, 2022
src/pages/top-up/Swap.tsx
Outdated
| getDesktopConfiguration(desktopUrl), | ||
| 'Unable to reach Desktop API. Is Swarm Desktop running?', | ||
| 'Unable to reach Desktop API - Swarm Desktop may not be running or API key is wrong', |
There was a problem hiding this comment.
We should be able to distinguish if the API key is wrong or Swarm Desktop server is not running, no?
src/utils/net.ts
Outdated
| @@ -27,6 +27,12 @@ export async function sendRequest( | |||
| method, | |||
| headers, | |||
| data, | |||
| }).catch(error => { | |||
| if (error?.response?.data) { | |||
| throw Error(JSON.stringify(error.response.data)) | |||
There was a problem hiding this comment.
I would provide a bit nicer Error 😅 At least format it like suggested. Maybe include path of the request as well?
Suggested change
| throw Error(JSON.stringify(error.response.data)) | |
| throw Error(`Request failed! Response: ${JSON.stringify(error.response.data)}`) |
Cafe137
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.