Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manifest): resolve node persistence after removal #4819

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(manifest): resolve node persistence after removal #4819

wants to merge 4 commits into from

Conversation

asabya
Copy link

@asabya asabya commented Sep 13, 2024

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

This PR fixes #4808. Where loading a manifest then removing forks from it would not persist in the next load.

zelig
zelig requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@zelig zelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat find. please simplify by just nil-ing the ref field

pkg/manifest/mantaray/persist.go Outdated Show resolved Hide resolved
pkg/manifest/mantaray/node.go Show resolved Hide resolved
@gacevicljubisa gacevicljubisa changed the title Mantaray manifest remove fork fix(manifest): resolve node persistence after removal Nov 25, 2024
@gacevicljubisa
Copy link
Contributor

@asabya this is the guide for commit msgs, linter will not allow merge if msgs are not in correct format. Currenltly this commit msg is not in correct format

@martinconic martinconic requested a review from zelig November 28, 2024 09:50
@istae
Copy link
Member

istae commented Jan 9, 2025

@asabya can you pls fix the commit msg, see https://github.com/ethersphere/bee/actions/runs/11669094347/job/33647232645?pr=4819#step:5:41

@asabya asabya force-pushed the mantarayRemoveTest branch from 8787863 to b31b0db Compare January 10, 2025 06:15
@asabya asabya requested a review from istae as a code owner January 10, 2025 06:15
@asabya
Copy link
Author

asabya commented Jan 10, 2025

@asabya can you pls fix the commit msg, see https://github.com/ethersphere/bee/actions/runs/11669094347/job/33647232645?pr=4819#step:5:41

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acha-bill acha-bill Awaiting requested review from acha-bill acha-bill is a code owner

@martinconic martinconic Awaiting requested review from martinconic

@gacevicljubisa gacevicljubisa Awaiting requested review from gacevicljubisa

@zelig zelig Awaiting requested review from zelig

@istae istae Awaiting requested review from istae istae is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@asabya asabya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mantaray removed entry still persists
4 participants
@asabya @gacevicljubisa @istae @zelig