Static-Weaving failing due to erroneous generated persistence.xml

[jonnybecker]

I just tried static-weaving with new eclipselink-maven-plugin v2.7.4.
Weaving fails since the generated persistence.xml is erroneous. The class-entries don't have the full qualified name, but the class definition.

Generated persistence.xml:

<?xml version="1.0" encoding="UTF-8"?>
<persistence version="2.1"
    xmlns="http://xmlns.jcp.org/xml/ns/persistence"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/persistence http://xmlns.jcp.org/xml/ns/persistence/persistence_2_1.xsd">
    <persistence-unit name="regid-core" transaction-type="RESOURCE_LOCAL">
        <provider>org.eclipse.persistence.jpa.PersistenceProvider</provider>
        <properties>
            <property name="eclipselink.weaving" value="static"/>
        </properties>
        <class>public abstract class com.foo.domain.entities.BaseVersionEntity&lt;I&gt; extends com.foo.domain.entities.BaseEntity&lt;I&gt;</class>
        <class>...</class>
    </persistence-unit>
</persistence>

My setup:

• Windows 10
• Java 8/11
• Maven 3.5.3

[ethlo]

Thanks for the report. The issue should be fixed and is released in 2.7.4.1-SNAPSHOT

[jonnybecker]

Thanks for the quick reaction. Any release-dates for 2.7.4.1 scheduled so far?
I'm asking, since we switched to Java11 and in 2.7.1.1 static-weaving isn't working (for us?).

[ethlo]

It is released 👍

…

On Thu, Sep 26, 2019, 12:09 jonnybecker ***@***.***> wrote: Thanks for the quick reaction. Any release-dates for 2.7.4.1 scheduled so far? I'm asking, since we switched to Java11 and in 2.7.1.1 static-weaving isn't working (for us?). — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#26?email_source=notifications&email_token=AAKSB4MRNA7DKMMC7LYF4YTQLSC4VA5CNFSM4IYHGWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7VBVZQ#issuecomment-535436006>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKSB4LAUPE4WFS43MP53U3QLSC4VANCNFSM4IYHGWRQ> .

[ethlo]

Were you able to use version 2.7.4.1 with your Java 11 build?

[jonnybecker]

Seems to work, thanks a lot! But I had to add an extra dependency (bundle) for the weaving process (see below).

<pluginManagement>
  <plugins>
	<plugin>
	  <groupId>com.ethlo.persistence.tools</groupId>
	  <artifactId>eclipselink-maven-plugin</artifactId>
	  <version>2.7.4.1</version>
	  <dependencies>
		<dependency>
		  <groupId>org.glassfish.jaxb</groupId>
		  <artifactId>jaxb-runtime</artifactId>
		  <version>2.3.2</version>
		</dependency>
	  </dependencies>
	</plugin>
        ...

Which dependencies do I really need for the weaving?

[ethlo]

That should be the only one. That is due to the fact that Java 11 (9+) is not shipping with JAXB libraries. Will consider adding it as a dependency for the next release. Please feel free to open another issue for it. Thank you.

…

On Tue, Oct 1, 2019 at 8:19 AM jonnybecker ***@***.***> wrote: Seems to work, thanks a lot! But I had to add an extra dependency (bundle) for the weaving process (see below). <pluginManagement> <plugins> <plugin> <groupId>com.ethlo.persistence.tools</groupId> <artifactId>eclipselink-maven-plugin</artifactId> <version>2.7.4.1</version> <dependencies> <dependency> <groupId>org.glassfish.jaxb</groupId> <artifactId>jaxb-runtime</artifactId> <version>2.3.2</version> </dependency> </dependencies> </plugin> ... Which dependencies do I really need for the weaving? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#26?email_source=notifications&email_token=AAKSB4N623WEVNLA4TRAWG3QMLTWPA5CNFSM4IYHGWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAADQGY#issuecomment-536885275>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKSB4MX4E73CQLXEBVIIPLQMLTWPANCNFSM4IYHGWRQ> .