fix endless loop when validator set cannot be loaded on dead chain #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnabasbusa
approved these changes
Oct 14, 2024
pk910
added a commit
that referenced
this pull request
Oct 15, 2024
pk910
added a commit
that referenced
this pull request
Oct 16, 2024
…epoch-0 fix loading validator set for epoch 0 (fix #151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently seen on https://dora.ssz-devnet-0.ethpandaops.io
There is no validator set available as there is no blocks in the network and no epoch stats are loaded.
Due to an issue in the
GetCanonicalValidatorSet, dora gets stuck in an endess loop, trying to iterate to the parent of epoch 0, which obviously doesn't work.The error propagates down to several pages and other parts of the code as they're all calling the GetCanonicalValidatorSet` function:
