Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the generation process of private key #100

Closed
mhchia opened this issue Nov 12, 2018 · 0 comments · Fixed by #113
Closed

Fix the generation process of private key #100

mhchia opened this issue Nov 12, 2018 · 0 comments · Fixed by #113

Comments

@mhchia
Copy link
Collaborator

mhchia commented Nov 12, 2018

What is wrong?

With a fixed seed, we don't always get the same private key, due to the randomness added in the process of generating RSA private key. We need this process to be deterministic for easier testing. This is discovered by @NIC619

How can it be fixed?

Use seed directly as the private key for testing
This was referenced Nov 15, 2018
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change key gen algo NIC619/sharding-p2p-poc
1 participant
@mhchia