Change key gen algo #113
Merged
Change key gen algo #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhchia
requested changes
Nov 18, 2018
cli.go
Outdated
| if err != nil { | ||
| logger.Fatalf("Failed to request PID from RPC server, err: %v", rpcAddr, err) | ||
| } | ||
| logger.Debugf("rpcclient:ShowPID: result=%v", res) |
There was a problem hiding this comment.
IMO it will be more appropriate to print the result to the stdout
Suggested change
| logger.Debugf("rpcclient:ShowPID: result=%v", res) | |
| peerIDStr := marshalToJSONString(res.PID) | |
| fmt.Println(peerIDStr) |
pb/rpc/rpc.proto
Outdated
| message RPCShowPIDRequest { | ||
| } | ||
| message RPCShowPIDResponse { | ||
| string PID = 1; |
There was a problem hiding this comment.
Would you mind follow the convention to use
Suggested change
| string PID = 1; | |
| string peerID = 1; |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #100
(RSA provided by Go Crypto package prevents deterministic key generation, see: https://github.com/golang/go/blob/6269dcdc24d74379d8a609ce886149811020b2cc/src/crypto/rsa/rsa.go#L223)
How was it fixed?
Was instead trying to remove
seedall at once but found that ECDSA provided can do deterministic key generation.Cute Animal Picture